DeveloperGuide: Difference between revisions
From The Battle for Wesnoth Wiki
Improve svn commits recommandations |
m →Commits |
||
| Line 1: | Line 1: | ||
== Commits == | == Commits == | ||
* Setting up developer | * Setting up developer access to the repository: [[WesnothRepository#Commit_access]] | ||
* Register to commit mailing list: https://mail.gna.org/listinfo/wesnoth-commits or get the list moderator to approve commit messages from you otherwise | * Register to commit mailing list: https://mail.gna.org/listinfo/wesnoth-commits or get the list moderator to approve commit messages from you otherwise | ||
* Trunk should compile and work after commit | * Trunk should compile and work after commit | ||
| Line 11: | Line 11: | ||
** Mention "bug #1234" for automatic cc to that gna bug number | ** Mention "bug #1234" for automatic cc to that gna bug number | ||
** Mention a developer's IRC name will ping him on IRC (when the bot report it), and if he's not there, he may see it on the IRC logs | ** Mention a developer's IRC name will ping him on IRC (when the bot report it), and if he's not there, he may see it on the IRC logs | ||
== Bugs management == | == Bugs management == | ||
* Change status of fixed bugs to "Fixed" when committed | * Change status of fixed bugs to "Fixed" when committed | ||
Revision as of 16:36, 20 March 2013
Commits
- Setting up developer access to the repository: WesnothRepository#Commit_access
- Register to commit mailing list: https://mail.gna.org/listinfo/wesnoth-commits or get the list moderator to approve commit messages from you otherwise
- Trunk should compile and work after commit
- Few small commits are better than a big one (hard to review), so when possible split it in working parts with info about where you are going
- Be on #wesnoth-dev IRC channel and coordinate with other developers. Bots report commits and some devs may ask you a question about it.
- Don't forget changelogs: changelog for any (significant enough) changes and player_changelog for changes visible to users.
- Always check your changes before commit (use svn diff)
- Commit message:
- Mention any change, especially if some are unrelated to the main one (but you should use separated commits for this).
- Mention "bug #1234" for automatic cc to that gna bug number
- Mention a developer's IRC name will ping him on IRC (when the bot report it), and if he's not there, he may see it on the IRC logs
Bugs management
- Change status of fixed bugs to "Fixed" when committed
- Change status of fixed bugs to "Closed" when released, see ReportingBugs#Bug_protocol for details
- Check if there is new bugs relevant to your code and if any, assign them to you.
See also
This page was last edited on 20 March 2013, at 16:36.