Difference between revisions of "Talk:GUIToolkitWML"

From The Battle for Wesnoth Wiki
m (Feedback)
(2 intermediate revisions by 2 users not shown)
Line 1: Line 1:
=Comments to GUI design documents by Zaroth=
+
== Feedback ==
* Makefile.am - remove this line in creating_widgets_and_dialogs.tex? (since there is no more support for autotools afaik)
 
* I didn't understand the sentence: "is already mentioned in the header file and it the one
 
used here uses several static helper functions to do it's job" (same file) - could you somehow rephrase it?
 
* "and whether only the optional ones are set is up to the designer of the dialog" - didn't you mean "the mandatory ones" here?
 
  
Feel free to delete this talk page after you've read it. Especially since I'm not sure if it's the right place in wiki to put the comments about the design document anyway...
+
There are two Resolution sections, mostly redundant
 +
 
 +
popup_* - might want to mention the word "tooltip" in there - I assume that's what a "popup" is
 +
 
 +
Settings > has_helptip_message - "The string used to append the tooltip " should that be "The string used to append to the tooltip" (assuming that's how it works)?
 +
 
 +
"A linked group needs to have at least one size fixed. " - one fixed size?
 +
 
 +
Toggle Button:
 +
 
 +
# GUIToolkitWML#Button is a link that doesn't seem to go anywhere (yet?)
 +
# "List if the id's that have generate a return value:" - this looks like a list of the valid values of return_value_id. I have no idea what that phrase means as written. Also, quit (an alias for cancel) is missing

Revision as of 10:53, 25 September 2024

Feedback

There are two Resolution sections, mostly redundant

popup_* - might want to mention the word "tooltip" in there - I assume that's what a "popup" is

Settings > has_helptip_message - "The string used to append the tooltip " should that be "The string used to append to the tooltip" (assuming that's how it works)?

"A linked group needs to have at least one size fixed. " - one fixed size?

Toggle Button:

  1. GUIToolkitWML#Button is a link that doesn't seem to go anywhere (yet?)
  2. "List if the id's that have generate a return value:" - this looks like a list of the valid values of return_value_id. I have no idea what that phrase means as written. Also, quit (an alias for cancel) is missing