User:Ejls/GSoC 2012/Whiteboard Backend Refactoring - Revision history

Egallager: link cleanup

2023-04-24T02:36:33Z

link cleanup

Ejls: typo

2012-04-10T02:41:39Z

typo

Ejls: Formating

2012-04-10T02:38:09Z

Formating

Ejls: update

2012-04-10T02:03:36Z

update

Show changes

Ejls: update

2012-04-05T23:39:07Z

update

Show changes

Ejls: ToC update

2012-04-01T02:14:08Z

ToC update

Ejls: (more nicely)

2012-04-01T02:11:30Z

(more nicely)

Ejls: Making it SummerOfCodeIdeas-friendly

2012-04-01T02:10:09Z

Making it SummerOfCodeIdeas-friendly

Ejls: mark the proposal as submitted to google

2012-04-01T02:08:03Z

mark the proposal as submitted to google

Ejls: readability

2012-03-31T16:36:04Z

readability

@@ Line 119: / Line 119: @@
 {{User:Ejls/GSoC 2012/Questionnaire
 |<!-- 4.1) Did you select a project from our list? If that is the case, what project did you select? What do you want to especially concentrate on? -->
-''This is a summary, more details can be found [http://wiki.wesnoth.org/User:Ejls/GSoC%202012/Whiteboard%20Backend%20Refactoring#Proposal here].''
+''This is a summary, more details can be found [[User:Ejls/GSoC%202012/Whiteboard%20Backend%20Refactoring#Proposal|here]].''
-I originally chose [[SoC Ideas Whiteboard Backend Refactoring 2012]], however it evolved a lot thanks to Gabba and Crab. This project is the only one not adding any feature for the user, the main goal is to refactor code, write test and documentation. It follows [http://wiki.wesnoth.org/GSoC-WesnothWhiteboard_Gabba Gabba's project] and [http://wiki.wesnoth.org/User:Tschmitz tschmitz's project] on the Whiteboard. Although it doesn't add any feature for the user in itself, I hope it'll help future development of the Whiteboard.<!--
+I originally chose [[SoC Ideas Whiteboard Backend Refactoring 2012]], however it evolved a lot thanks to Gabba and Crab. This project is the only one not adding any feature for the user, the main goal is to refactor code, write test and documentation. It follows [[GSoC-WesnothWhiteboard_Gabba|Gabba's project]] and [[User:Tschmitz|tschmitz's project]] on the Whiteboard. Although it doesn't add any feature for the user in itself, I hope it'll help future development of the Whiteboard.<!--
 -->|<!-- 4.2) If you have invented your own project, please describe the project and the scope. -->
 I chose a project from the list, namely [[SoC Ideas Whiteboard Backend Refactoring 2012]]. C.f. above answer.<!--
@@ Line 127: / Line 127: @@
 I liked the idea behind the Whiteboard, I think it might be a big plus to Wesnoth. Furthermore, I liked how C++ is used in its code (especially the heavy use of SBRM). However it looks like the Whiteboard is not widely used, and I would like to help changing that! :)<!--
 -->|<!-- 4.4) Include an estimated timeline for your work on the project. Don't forget to mention special things like "I booked holidays between A and B" and "I got an exam at ABC and won't be doing much then". -->
-''This is a summary, more details can be found [http://wiki.wesnoth.org/User:Ejls/GSoC%202012/Whiteboard%20Backend%20Refactoring#Timeline here].''
+''This is a summary, more details can be found [[User:Ejls/GSoC%202012/Whiteboard%20Backend%20Refactoring#Timeline|here]].''
 I separated my summer in five phases:
@@ Line 138: / Line 138: @@
 ::→ Finish the design document. Finish the ''polishing''. Test. Test. Test.<!--
 -->|<!-- 4.5) Include as much technical detail about your implementation as you can -->
-''This is a summary, more details can be found [http://wiki.wesnoth.org/User:Ejls/GSoC%202012/Whiteboard%20Backend%20Refactoring#Proposal here].''
+''This is a summary, more details can be found [[User:Ejls/GSoC%202012/Whiteboard%20Backend%20Refactoring#Proposal|here]].''
 I separated my project in five tasks:

@@ Line 424: / Line 424: @@
 This approach creates a dependency bottleneck: it collects in a single function knowledge about all classes deriving from <code>action</code>.
-A more sensible approach would be to use an ''object factory''.
+A more sensible approach would be to use ''object factories''.
 The implementation is not very long nor difficult and the resulting code will be more elegant.

@@ Line 172: / Line 172: @@
 |-
 |style="border:1px dotted #AAA;padding:5px;"|<code>side_actions</code> complexity
-|style="border:1px dotted #AAA;padding:5px;"|[[#side_actions|<tt>side_actions</tt> refactoring]]
+|style="border:1px dotted #AAA;padding:5px;"|[[#side_actions|<code>side_actions</code> refactoring]]
 |-
 |style="border:1px dotted #AAA;padding:5px;"|Redundancy between <code>mapbuilder</code> and <code>validate_visitor</code>
@@ Line 178: / Line 178: @@
 |-
 |style="border:1px dotted #AAA;padding:5px;"|Highlighter slowness
-|style="border:1px dotted #AAA;padding:5px;"|[[#side_actions|<tt>side_actions</tt> refactoring]] and [[#visitorhier|Visitor hierarchy refactoring]]
+|style="border:1px dotted #AAA;padding:5px;"|[[#side_actions|<code>side_actions</code> refactoring]] and [[#visitorhier|Visitor hierarchy refactoring]]
 |-
 |style="border:1px dotted #AAA;padding:5px;"|Action handling decentralization

@@ Line 20: / Line 20: @@
 [[#Description|Description]]<br />
 [[#Contact|Contact]]<br />
-<!--[[#SoC Application|SoC Application]]<br />
+[[#SoC Application|SoC Application]]<br />
--->[[#Questionnaire|Questionnaire]]<br />
+[[#Questionnaire|Questionnaire]]<br />
 :[[#1) Basics|1 - Basics]]<br />
 :[[#2) Experience|2 - Experience]]<br />

@@ Line 73: / Line 73: @@
      ***********************************************************************-->
 ==SoC Application==
-Submitted to google
+Submitted to google<!--
+-->
 <!--***********************************************************************
      *                             * Contact *                             *
@@ Line 83: / Line 82: @@
      * must only contain the IRC nick identifying the author.              *
      ***********************************************************************-->
 {|
 |-

@@ Line 5: / Line 5: @@
 -->{{SoC2012Student}}<!--
 -->[[Category:SoC_Ideas_Whiteboard_Backend_Refactoring_2012]]<!--
--->'''''Note: This proposal is in continuous construction, if you have any remark, please drop me a line on IRC or on the [[{{TALKPAGENAME}}|talk page]].'''''<br /><br />
+-->'''''Note: This proposal is in construction, if you have any remark, please drop me a line on IRC or on the [[{{TALKPAGENAME}}|talk page]].'''''<br /><br />
 <!--***********************************************************************
@@ Line 61: / Line 61: @@
 =====Étienne Simon - Whiteboard backend polishing=====
 My project is to make the whiteboard code cleaner and to redesign small parts of it to speed it up. Apart from the visitor hierarchy refactoring, the global design of the whiteboard won't be changed, each part will be reviewed individually. I'm not only planning to improve the whiteboard backend, but also to document the overall design and each part of it as well as to write a wide variety of test to improve its stability.<!--
+-->
-    ***********************************************************************
+<!--***********************************************************************
      *                         * SoC Application *                         *
      *                         *******************                         *
@@ Line 71: / Line 71: @@
      * otherwise it'll appear in the "Student proposals not submitted to   *
      * google" section.                                                    *
-     ***********************************************************************
+     ***********************************************************************-->
 ==SoC Application==
-Not yet submitted.
+Submitted to google.
-    ***********************************************************************
      *                             * Contact *                             *
      *                             ***********                             *

@@ Line 301: / Line 301: @@
 =====<span id="visitorhier.example">Example</span>=====
 Here is an example function that would speed up <tt>highlight_visitor</tt>.
-  action_ptr action_inquirer::action_at(map_location const &h){
+  action_ptr action_inquirer::action_at(map_location const &hex){
-      side_actions::iterator r;
+      side_actions::iterator result;
-      foreach(team& t, *resources::teams){
+      foreach(team& side, *resources::teams){
-          side_actions sa = t.get_side_actions();
+          side_actions actions = side.get_side_actions();
-          if((r=sa.find_action_at(h)) != sa.end())
+          if((result = actions.find_action_at(hex)) != actions.end())
-              return *r;
+              return *result;
+      }
       return action_ptr();