Talk:ReferenceWMLDump - Revision history

Monochromatic: moved Talk:VariablesWML to Talk:ReferenceWMLDump: Creating this page to dump unnecessary ReferenceWML Pages, just for history's sake. In this case, VariablesWML is now part of SyntaxWML (to-be-renamed).

2011-04-29T02:03:12Z

moved Talk:VariablesWML to Talk:ReferenceWMLDump: Creating this page to dump unnecessary ReferenceWML Pages, just for history's sake. In this case, VariablesWML is now part of SyntaxWML (to-be-renamed).

Sapient at 21:42, 16 July 2007

2007-07-16T21:42:46Z

Meriton: Request for clarification: Substitution mode of [set_variable]value= in stable branch

2007-07-16T11:51:48Z

Request for clarification: Substitution mode of [set_variable]value= in stable branch

Meriton at 11:41, 16 July 2007

2007-07-16T11:41:17Z

Sapient at 07:34, 16 July 2007

2007-07-16T07:34:11Z

Meriton: a comment and a question

2007-07-15T20:17:43Z

a comment and a question

Kernigh: Therefore my claim (that 1.1.5 eliminated simple substitution) was incorrrect.

2007-07-15T20:00:16Z

Therefore my claim (that 1.1.5 eliminated simple substitution) was incorrrect.

Sapient at 19:50, 15 July 2007

2007-07-15T19:50:14Z

Kernigh: Oops, I misformated my code. I will fix that now.

2007-07-15T14:35:48Z

Oops, I misformated my code. I will fix that now.

Kernigh: I suggest that "$foo_$b" was not a valid complex substitution.

2007-07-15T14:35:01Z

I suggest that "$foo_$b" was not a valid complex substitution.

← Older revision		Revision as of 21:42, 16 July 2007
Line 84:		Line 84:
	Inspection of the save file revealed that "test" had been set to "bar".		Inspection of the save file revealed that "test" had been set to "bar".

−	What is the substitution mode for [set_variable]value= in the current stable branch?	+	What is the substitution mode for [set_variable]value= in the current stable branch? --Meriton
		+
		+
		+	Answer: try it and see. If I remember correctly, [set_variable]value= performs simple substitution in the stable branch. Also, there was an effort primarily by Noyga to add complex substitution to lots of keys where he thought it would be useful. Unfortunately, he didn't document these changes as he went along. That's why the page is out of date. If you want to painstakingly retrace the evolution of variable substitution in the stable branch, be my guest, but I have moved on to improving the development branch. --Sapient

← Older revision		Revision as of 11:51, 16 July 2007
Line 69:		Line 69:

	Ok, thanks for the clarification. --Meriton		Ok, thanks for the clarification. --Meriton
		+
		+	=== Substitution mode of [set_variable]value= in stable branch ===
		+
		+	In the forums, governor claimed
		+	: {VARIABLE var1 $var2.xxxx} is valid.
		+	which desugars to
		+	[set_variable]
		+	name=var1
		+	value=$var2.xxxx
		+	[/set_variable]
		+	I tested this in 1.2.5 with the code
		+	{VARIABLE foo bar}
		+	{VARIABLE test $foo}
		+	Inspection of the save file revealed that "test" had been set to "bar".
		+
		+	What is the substitution mode for [set_variable]value= in the current stable branch?

← Older revision		Revision as of 11:41, 16 July 2007
Line 67:		Line 67:

	Incorrect. I suggest you disregard Kernigh's statement, because it is misleading and false. There is still lots of simple substitution in the stable branch. (Including the bug with complex substitution sometimes reverting to simple substitution when the first character is '$'). If you are doing anything complex with WML you should be using the development branch because many improvements have been made. --Sapient		Incorrect. I suggest you disregard Kernigh's statement, because it is misleading and false. There is still lots of simple substitution in the stable branch. (Including the bug with complex substitution sometimes reverting to simple substitution when the first character is '$'). If you are doing anything complex with WML you should be using the development branch because many improvements have been made. --Sapient
		+
		+	Ok, thanks for the clarification. --Meriton

← Older revision		Revision as of 07:34, 16 July 2007
Line 65:		Line 65:

	Let me see if I got this right: In theory, all attributes that perform any substitution perform complex substitution, but due to a bug, complex substitution sometimes does simple substitution instead. We therefore tell users that only simple substitution is performed in the stable branch, because that is the only thing that is guaranteed to work. [[User:Meriton\|Meriton]] 22:17, 15 July 2007 (CEST)		Let me see if I got this right: In theory, all attributes that perform any substitution perform complex substitution, but due to a bug, complex substitution sometimes does simple substitution instead. We therefore tell users that only simple substitution is performed in the stable branch, because that is the only thing that is guaranteed to work. [[User:Meriton\|Meriton]] 22:17, 15 July 2007 (CEST)
		+
		+	Incorrect. I suggest you disregard Kernigh's statement, because it is misleading and false. There is still lots of simple substitution in the stable branch. (Including the bug with complex substitution sometimes reverting to simple substitution when the first character is '$'). If you are doing anything complex with WML you should be using the development branch because many improvements have been made. --Sapient

@@ Line 38: / Line 38: @@
 : When I made a copy of 2p - Blitz with this event, side 1 was able to recruit Elvish Sharpshooters.
-: To show why your test failed, I suggest that "$foo_$b" is not a valid complex suggestion. (I do not know why "$foo_$b" does not work; maybe there is a bug in 1.2.5, or I misunderstand how complex substitution works.) The wiki page claims that [message]message= allows complex substitution, so I extended your example to be:
+: To show why your test failed, I suggest that "$foo_$b" is not a valid complex suggestion. (I do not know why "$foo_$b" does not work; maybe there is a bug in 1.2.5, or I misunderstand how complex substitution works.)
   			{VARIABLE foo_bar 42}
@@ Line 59: / Line 63: @@
 : I have to admit that my previous claim (" Since Wesnoth 1.1.5, all simple substitution was eliminated in favor of complex substitution, which is more versatile.") was incorrect, because of the above description of how Wesnoth sometimes does "switch back to simple substitution". --[[User:Kernigh|Kernigh]] 22:00, 15 July 2007 (CEST)

← Older revision	Revision as of 02:03, 29 April 2011
(No difference)

← Older revision		Revision as of 20:00, 15 July 2007
Line 56:		Line 56:
	: When I tested this, side 2 failed to gain 42 gold, and the message box can up with an empty message! --[[User:Kernigh\|Kernigh]] 16:35, 15 July 2007 (CEST)		: When I tested this, side 2 failed to gain 42 gold, and the message box can up with an empty message! --[[User:Kernigh\|Kernigh]] 16:35, 15 July 2007 (CEST)

−	There is a bug with complex substitution in the stable branch; it the value starts with '$' as the very first character then it will (sometimes) switch back to simple substitution. This bug was fixed by eliminating simple substitution in the development branch. As a workaround, you can put a space as the first charatcer in the message, like this: message=" $foo_$b".	+	There is a bug with complex substitution in the stable branch; it the value starts with '$' as the very first character then it will (sometimes) switch back to simple substitution. This bug was fixed by eliminating simple substitution in the development branch. As a workaround, you can put a space as the first charatcer in the message, like this: message=" $foo_$b". --[http://www.wesnoth.org/mw/index.php?title=Talk:VariablesWML&diff=16471&oldid=16468 ''unsigned talk from Sapient'']
		+
		+	: I have to admit that my previous claim (" Since Wesnoth 1.1.5, all simple substitution was eliminated in favor of complex substitution, which is more versatile.") was incorrect, because of the above description of how Wesnoth sometimes does "switch back to simple substitution". --[[User:Kernigh\|Kernigh]] 22:00, 15 July 2007 (CEST)

← Older revision		Revision as of 19:50, 15 July 2007
Line 55:		Line 55:

	: When I tested this, side 2 failed to gain 42 gold, and the message box can up with an empty message! --[[User:Kernigh\|Kernigh]] 16:35, 15 July 2007 (CEST)		: When I tested this, side 2 failed to gain 42 gold, and the message box can up with an empty message! --[[User:Kernigh\|Kernigh]] 16:35, 15 July 2007 (CEST)
		+
		+	There is a bug with complex substitution in the stable branch; it the value starts with '$' as the very first character then it will (sometimes) switch back to simple substitution. This bug was fixed by eliminating simple substitution in the development branch. As a workaround, you can put a space as the first charatcer in the message, like this: message=" $foo_$b".

@@ Line 25: / Line 25: @@
 : Further, the following example passes wesnoth 1.2.5, and at least demonstrates that the [allow_recruit]type= key permits complex substitution:
-			# works in 1.2.5
+ 			# works in 1.2.5
-			[event]
+ 			[event]
-				name=start
+ 				name=start
-				{VARIABLE title "Sharpshooter"}
+ 				{VARIABLE title "Sharpshooter"}
-				{VARIABLE name title}
+ 				{VARIABLE name title}
-				[allow_recruit]
+ 				[allow_recruit]
-					type="Elvish $$name||"
+ 					type="Elvish $$name||"
-					side=1
+ 					side=1
-				[/allow_recruit]
+ 				[/allow_recruit]
-			[/event]
+ 			[/event]
 : When I made a copy of 2p - Blitz with this event, side 1 was able to recruit Elvish Sharpshooters.
@@ Line 40: / Line 40: @@
 : To show why your test failed, I suggest that "$foo_$b" is not a valid complex suggestion. (I do not know why "$foo_$b" does not work; maybe there is a bug in 1.2.5, or I misunderstand how complex substitution works.) The wiki page claims that [message]message= allows complex substitution, so I extended your example to be:
-			{VARIABLE foo_bar 42}
+ 			{VARIABLE foo_bar 42}
-			{VARIABLE b bar}
+ 			{VARIABLE b bar}
-			[gold]
+ 			[gold]
-				side=2
+ 				side=2
-				amount=$foo_$b
+ 				amount=$foo_$b
-				# broken in 1.2.5
+ 				# broken in 1.2.5
-			[/gold]
+ 			[/gold]
-−
-			[message]
+ 			[message]
-				speaker=narrator
+ 				speaker=narrator
-				message=$foo_$b
+ 				message=$foo_$b
-				# broken in 1.2.5
+ 				# broken in 1.2.5
-			[/message]
+ 			[/message]
 : When I tested this, side 2 failed to gain 42 gold, and the message box can up with an empty message! --[[User:Kernigh|Kernigh]] 16:35, 15 July 2007 (CEST)

← Older revision		Revision as of 14:35, 15 July 2007
Line 20:		Line 20:

	[[User:Meriton\|Meriton]] 15:25, 15 July 2007 (CEST)		[[User:Meriton\|Meriton]] 15:25, 15 July 2007 (CEST)
		+
		+	: In the source file wesnoth-1.2.5/changelog, under the section for "Wesnoth 1.1.5", it states, "all [event] tags shall perform complex substitution".
		+
		+	: Further, the following example passes wesnoth 1.2.5, and at least demonstrates that the [allow_recruit]type= key permits complex substitution:
		+
		+	# works in 1.2.5
		+	[event]
		+	name=start
		+	{VARIABLE title "Sharpshooter"}
		+	{VARIABLE name title}
		+	[allow_recruit]
		+	type="Elvish $$name\|\|"
		+	side=1
		+	[/allow_recruit]
		+	[/event]
		+
		+	: When I made a copy of 2p - Blitz with this event, side 1 was able to recruit Elvish Sharpshooters.
		+
		+	: To show why your test failed, I suggest that "$foo_$b" is not a valid complex suggestion. (I do not know why "$foo_$b" does not work; maybe there is a bug in 1.2.5, or I misunderstand how complex substitution works.) The wiki page claims that [message]message= allows complex substitution, so I extended your example to be:
		+
		+	{VARIABLE foo_bar 42}
		+	{VARIABLE b bar}
		+	[gold]
		+	side=2
		+	amount=$foo_$b
		+	# broken in 1.2.5
		+	[/gold]
		+
		+	[message]
		+	speaker=narrator
		+	message=$foo_$b
		+	# broken in 1.2.5
		+	[/message]
		+
		+	: When I tested this, side 2 failed to gain 42 gold, and the message box can up with an empty message! --[[User:Kernigh\|Kernigh]] 16:35, 15 July 2007 (CEST)